Hi Jean-Michel,
On 01/26/2015 02:52 PM, Jean-Michel Hautbois wrote:
> The bits are the same, but register is 0xf4 on ADV7611 instead of 0xfc.
> When reading back the value in log_status, differentiate both.
>
> Signed-off-by: Jean-Michel Hautbois <jean-michel.hautb...@vodalys.com>
> ---
> drivers/media/i2c/adv7604.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index e43dd2e..32e53e0 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -2310,8 +2310,12 @@ static int adv7604_log_status(struct v4l2_subdev *sd)
> (reg_io_0x02 & 0x04) ? "(16-235)" : "(0-255)",
> ((reg_io_0x02 & 0x04) ^ (reg_io_0x02 & 0x01)) ?
> "enabled" : "disabled");
> - v4l2_info(sd, "Color space conversion: %s\n",
> + if (state->info->type == ADV7604)
> + v4l2_info(sd, "Color space conversion: %s\n",
> csc_coeff_sel_rb[cp_read(sd, 0xfc) >> 4]);
> + else
> + v4l2_info(sd, "Color space conversion: %s\n",
> + csc_coeff_sel_rb[cp_read(sd, 0xf4) >> 4]);
>
> if (!is_digital_input(sd))
> return 0;
>
You need to add this register to the adv7604_chip_info struct, just like is
done for other registers that have this issue.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
