On 02/05/2015 09:28 AM, Aaron Wu wrote: > Rewrite the blackfin CAN driver into common style > V4 changes: remove unused variable in patch 2/2 > V3 changes: remove redundant cast in patch 2/2 > V2 changes: split patch into two parts > V1 changes: rewrite code into common style > > Signed-off-by: Aaron Wu <[email protected]>
The code looks good, the patch description can be improved though. Please replace the change history by a description what this patch does and why. For this kind of patch a single sentence would be enough, but rewrite into common style is to generic. (Same applies to 1/2) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
