On 11 February 2015 at 17:46, Ivan Khoronzhuk <[email protected]> wrote: > According to SMBIOSv3 specification the length of DMI table can be > up to 32bits wide. So use appropriate type to avoid overflow. > > It's obvious that dmi_num theoretically can be more than u16 also, > so it's can be changed to u32 or at least it's better to use int > instead of u16, but on that moment I cannot imagine dmi structure > count more than 65535 and it can require changing type of vars that > work with it. So I didn't correct it. > > Signed-off-by: Ivan Khoronzhuk <[email protected]>
Acked-by: Ard Biesheuvel <[email protected]> This should get a cc stable as well. -- Ard. > --- > drivers/firmware/dmi_scan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c > index fb16203..952e95c 100644 > --- a/drivers/firmware/dmi_scan.c > +++ b/drivers/firmware/dmi_scan.c > @@ -18,7 +18,7 @@ > static const char dmi_empty_string[] = " "; > > static u16 __initdata dmi_ver; > -static u16 dmi_len; > +static u32 dmi_len; > static u16 dmi_num; > /* > * Catch too early calls to dmi_check_system(): > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
