On 11 February 2015 at 18:10, Ivan Khoronzhuk <[email protected]> wrote: > > On 02/11/2015 11:53 AM, Ard Biesheuvel wrote: >> >> On 11 February 2015 at 17:46, Ivan Khoronzhuk >> <[email protected]> wrote: >>> >>> According to SMBIOSv3 specification the length of DMI table can be >>> up to 32bits wide. So use appropriate type to avoid overflow. >>> >>> It's obvious that dmi_num theoretically can be more than u16 also, >>> so it's can be changed to u32 or at least it's better to use int >>> instead of u16, but on that moment I cannot imagine dmi structure >>> count more than 65535 and it can require changing type of vars that >>> work with it. So I didn't correct it. >>> >>> Signed-off-by: Ivan Khoronzhuk <[email protected]> >> >> Acked-by: Ard Biesheuvel <[email protected]> >> >> This should get a cc stable as well. >> > > Pay attention that this patch has to be applied with patch 1/3.
Good point. Actually, I don't really see the need for patch #1, even if I agree that it would have been better to write it like you have in the first place. But leaving the dmi_len as u16 is clearly a bug on my part, so that should be fixed. @Matt: any thoughts? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
