The seq_printf return value, because it's frequently misused,
will eventually be converted to void.

See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
     seq_has_overflowed() and make public")

Signed-off-by: Joe Perches <j...@perches.com>
---
 arch/s390/pci/pci_debug.c    |  6 ++++--
 drivers/s390/cio/blacklist.c | 12 +++++++-----
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/arch/s390/pci/pci_debug.c b/arch/s390/pci/pci_debug.c
index 3229a2e..c22d440 100644
--- a/arch/s390/pci/pci_debug.c
+++ b/arch/s390/pci/pci_debug.c
@@ -45,8 +45,10 @@ static int pci_perf_show(struct seq_file *m, void *v)
 
        if (!zdev)
                return 0;
-       if (!zdev->fmb)
-               return seq_printf(m, "FMB statistics disabled\n");
+       if (!zdev->fmb) {
+               seq_puts(m, "FMB statistics disabled\n");
+               return 0;
+       }
 
        /* header */
        seq_printf(m, "FMB @ %p\n", zdev->fmb);
diff --git a/drivers/s390/cio/blacklist.c b/drivers/s390/cio/blacklist.c
index b3f791b..20314aa 100644
--- a/drivers/s390/cio/blacklist.c
+++ b/drivers/s390/cio/blacklist.c
@@ -330,18 +330,20 @@ cio_ignore_proc_seq_show(struct seq_file *s, void *it)
        if (!iter->in_range) {
                /* First device in range. */
                if ((iter->devno == __MAX_SUBCHANNEL) ||
-                   !is_blacklisted(iter->ssid, iter->devno + 1))
+                   !is_blacklisted(iter->ssid, iter->devno + 1)) {
                        /* Singular device. */
-                       return seq_printf(s, "0.%x.%04x\n",
-                                         iter->ssid, iter->devno);
+                       seq_printf(s, "0.%x.%04x\n", iter->ssid, iter->devno);
+                       return 0;
+               }
                iter->in_range = 1;
-               return seq_printf(s, "0.%x.%04x-", iter->ssid, iter->devno);
+               seq_printf(s, "0.%x.%04x-", iter->ssid, iter->devno);
+               return 0;
        }
        if ((iter->devno == __MAX_SUBCHANNEL) ||
            !is_blacklisted(iter->ssid, iter->devno + 1)) {
                /* Last device in range. */
                iter->in_range = 0;
-               return seq_printf(s, "0.%x.%04x\n", iter->ssid, iter->devno);
+               seq_printf(s, "0.%x.%04x\n", iter->ssid, iter->devno);
        }
        return 0;
 }
-- 
2.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to