On 25/02/15 19:22, Robert Abel wrote: > Hi Roger, > > On 25 Feb 2015 18:17, Roger Quadros wrote: >> How will the user know by looking at the kernel log that it was really an >> error? >> We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary >> to >> clearly show an Error message. >> >> You can probably reword it like "%s: Error!! GPMC CS %d..." > > I'll put "error" in there. But just for the record, it's this messaged > followed by a WARN that explains "failed to add child %s". > So I'd expect the user to put A and B together ;)
Sorry, my bad. We are in fact returning -1 in GPMC_SET_ONE(). So no need to add the "Error" string. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
