* Andy Lutomirski <l...@amacapital.net> wrote:

> >> I added that in and applied this patch.
> >
> > So this is not just slightly buggy, it's fundamentally 
> > wrong as well as it removes the possibility of an RSP 
> > value optimization from the 64-bit path, see my 
> > previous mail.
> 
> This is just trying to check that the function is 
> executing on the per-thread stack.  It was correct (and 
> fairly heavily tested by Tony) wither KERNEL_STACK_OFFSET 
> being nonzero, but we're checking the wrong page if 
> KERNEL_STACK_OFFSET becomes zero.
> 
> I don't think I understand your objection to this bit.

I object to the KERNEL_STACK_OFFSET removal patch you fixed 
here, not to the add-on fix in particular (which is correct 
in the context of that patch).

Thanks,

        Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to