(2015/02/27 19:52), He Kuang wrote: > The minus operator has higher precedence than ?: > Add parentheses around ?: fix this. > > Before this patch: > $ echo 'p:myprobe do_sys_open' > /sys/kernel/debug/tracing/kprobe_events > $ perf probe -l -k ../vmlinux > kprobes:myprobe (on do_sys_open) > > After this patch: > $ echo 'p:myprobe do_sys_open' > /sys/kernel/debug/tracing/kprobe_events > $ perf probe -l -k ../vmlinux > kprobes:myprobe (on [email protected]/fs/open.c)
Thanks for finding this bug! Acked-by: Masami Hiramatsu <[email protected]> > > Signed-off-by: He Kuang <[email protected]> > --- > tools/perf/util/probe-event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 919937e..bed8d0f 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -150,7 +150,7 @@ static u64 kernel_get_symbol_address_by_name(const char > *name, bool reloc) > sym = __find_kernel_function_by_name(name, &map); > if (sym) > return map->unmap_ip(map, sym->start) - > - (reloc) ? 0 : map->reloc; > + ((reloc) ? 0 : map->reloc); > } > return 0; > } > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
