Hi Greg,

After merging the staging tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from include/linux/module.h:17:0,
                 from drivers/staging/sm750fb/sm750.c:2:
drivers/staging/sm750fb/sm750.c: In function '__check_g_option':
drivers/staging/sm750fb/sm750.c:1436:14: error: 'g_option' undeclared (first 
use in this function)
 module_param(g_option,charp,S_IRUGO);
              ^

Caused by commit 81dee67e215b ("staging: sm750fb: add sm750 to staging").

This driver also produced a large number of warnings ... a lot like this:

drivers/staging/sm750fb/sm750.c: In function 'lynxfb_ops_mmap':
drivers/staging/sm750fb/sm750.c:533:2: warning: format '%x' expects argument of 
type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=]
  printk("lynxfb mmap pgoff: %x\n", vma->vm_pgoff);
  ^

Also note:

In file included from drivers/staging/sm750fb/ddk750_mode.h:4:0,
                 from drivers/staging/sm750fb/ddk750.h:15,
                 from drivers/staging/sm750fb/sm750_hw.c:24:
drivers/staging/sm750fb/ddk750_chip.h:4:0: warning: "SM750LE_REVISION_ID" 
redefined
 #define SM750LE_REVISION_ID (char)0xfe
 ^
In file included from drivers/staging/sm750fb/sm750_hw.c:23:0:
drivers/staging/sm750fb/sm750_hw.h:8:0: note: this is the location of the 
previous definition
 #define SM750LE_REVISION_ID (unsigned char)0xfe
 ^

I have disabled this driver for now, please let me know when it is OK
to enable it again.

From: Stephen Rothwell <s...@canb.auug.org.au>
Date: Tue, 10 Mar 2015 16:02:45 +1100
Subject: [PATCH] staging: disable the Silicon Motion SM750 framebuffer support

due to build problems

Signed-off-by: Stephen Rothwell <s...@canb.auug.org.au>
---
 drivers/staging/sm750fb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/sm750fb/Kconfig b/drivers/staging/sm750fb/Kconfig
index c40d088a4d3b..24f3a7f787da 100644
--- a/drivers/staging/sm750fb/Kconfig
+++ b/drivers/staging/sm750fb/Kconfig
@@ -1,6 +1,7 @@
 config FB_SM750
        tristate "Silicon Motion SM750 framebuffer support"
        depends on FB && PCI
+       depends on BROKEN
        help
          Frame buffer driver for the Silicon Motion SM750 chip
          with 2D accelearion and dual head support.
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    s...@canb.auug.org.au

Attachment: pgpGPTKT6UrZU.pgp
Description: OpenPGP digital signature

Reply via email to