On Tue, Mar 10, 2015 at 9:42 AM, Oleg Nesterov <o...@redhat.com> wrote: > Well, the patch looks "obviously fine" to me, but this is all I can say. > > I mean, I simply can't understand this __pad0/ifdef(CONFIG_X86_32), it > looks as if ->ss was specially excluded for unknown reason from the very > beginning.
I assume it was confusion in the very early days of x86_64. Andi? > > On 03/10, Andy Lutomirski wrote: >> >> > --- a/arch/x86/include/uapi/asm/sigcontext.h >> > +++ b/arch/x86/include/uapi/asm/sigcontext.h >> > @@ -179,7 +179,7 @@ struct sigcontext { >> > __u16 cs; >> > __u16 gs; >> > __u16 fs; >> > - __u16 __pad0; >> > + __u16 ss; > > I do not know the rules for include/uapi/ ... > > OK, nobody should ever use __pad0, so probably it is safe to rename it. > OTOH, an application can (say) try to print all members for debugging > purposes, it won't compile after this change. Yeah, I don't really know what the rules are. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/