On Wed, 2015-03-11 at 10:14 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2015-03-10 at 17:03 -0600, Alex Williamson wrote: > > > > return (PAGE_SHIFT + compound_order(compound_head(page) >= page_shift); > > > > > > This won't be "bool" though. > > > > Yes, it will. > > Don't you have your parenthesis in the wrong place, Alex ? :-)
Probably, but the compiler will warn about that. > > > This will (I'll do this) > > > > > > shift = PAGE_SHIFT + compound_order(compound_head(page)); > > > return (shift >= page_shift); > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
