On Wed, Mar 11, 2015 at 02:22:09PM -0400, Vivien Didelot wrote: > From: Guenter Roeck <li...@roeck-us.net> > > Up to now, is_visible can only be used to either remove visibility > of a file entirely or to add permissions, but not to reduce permissions. > This makes it impossible, for example, to use DEVICE_ATTR_RW to define > file attributes and reduce permissions to read-only. > > This behavior is undesirable and unnecessarily complicates code which > needs to reduce permissions; instead of just returning the desired > permissions, it has to ensure that the permissions in the attribute > variable declaration only reflect the minimal permissions ever needed. > > Change semantics of is_visible to only use the permissions returned > from it instead of oring the returned value with the hard-coded > permissions. > > Cc: Vivien Didelot <vivien.dide...@savoirfairelinux.com> > Signed-off-by: Guenter Roeck <li...@roeck-us.net> > --- > fs/sysfs/group.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)
Why have you not signed off on this patch if you sent it to me? Don't you agree with it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
