2015-03-23 13:34 GMT+01:00 Lee Jones <[email protected]>: > On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: > >> From: Chanwoo Choi <[email protected]> >> >> This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is >> equal to S2MPS14's RTC. >> >> Cc: Lee Jones <[email protected]> >> Suggested-by: Krzysztof Kozlowski <[email protected]> >> Signed-off-by: Chanwoo Choi <[email protected]> >> Signed-off-by: Krzysztof Kozlowski <[email protected]> >> >> --- >> >> Changes since v1: >> 1. New patch. >> --- >> drivers/mfd/sec-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied, thanks.
Hi, Sorry for the mess but we did this wrong. The S2MPS13 RTC is slightly different than S2MPS14 and that difference is important. It is embarrassing... but the difference was written small-print as a note in datasheet. Really. I found it after carefully comparing two PDFs. The impact of difference was not detected because of error in DTS for Exynos5433-based board. This patch should be dropped (or reverted) and "s2mps13-rtc" should be used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should have its own support for RTC which I will add in separate patch. Lee, once again sorry for the mess. How would you like to proceed? Can you just drop this commit? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
