On Fri, 2015-04-03 at 19:51 +0300, Dan Carpenter wrote: > On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote: > > Removes variable comparison with 0 by using !. > > Sometimes testing for zero makes sense. > When you write code, you are > telling a story. If you are talking about zero as a number then it > can make sense. If it's zero as a boolean then it doesn't make sense.
Very true. > Also strcmp() and similar should always be done as == 0, < 0 or != 0 > because that is the idiom: Less true. When testing for equality, !strcmp is very common. There are ~2500 uses of !strcmp in the kernel tree vs ~1500 uses of strcmp() == or != -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
