On Tue, 7 Apr 2015 16:38:02 +0100
Daniel Thompson <[email protected]> wrote:
> void arch_trigger_all_cpu_backtrace(bool include_self)
> {
> - struct nmi_seq_buf *s;
> - int len;
> - int cpu;
> int i;
> int this_cpu = get_cpu();
>
> - if (test_and_set_bit(0, &backtrace_flag)) {
> + if (0 != printk_nmi_backtrace_prepare()) {
Not sure what the others think, but I hate this polish notation for
compares. One does not say "if zero does not equal
printk_nmi_backtrace_prepare()", they say "if
printk_nmi_backtrace_prepare() does not return zero".
And the reason for polish notation is to prevent the:
if (x = 0)
mistake. Which gcc warns about anyway. Also, this doesn't even pertain
to this code because:
if (printk_nmi_backtrace_prepare() = 0)
would fail to compile.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
