On Thu, 9 Apr 2015, Fabian Frederick wrote: > if()/BUG conversion to BUG_ON must be avoided when there's side effect > in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG > is not defined. > > Inspired-by: J. Bruce Fields <bfie...@fieldses.org> > Suggested-by: Julia Lawall <julia.law...@lip6.fr> > Signed-off-by: Fabian Frederick <f...@skynet.be>
Acked by: Julia Lawall <julia.law...@lip6.fr> modulo the suggestion below. > --- > scripts/coccinelle/misc/bugon.cocci | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/bugon.cocci > b/scripts/coccinelle/misc/bugon.cocci > index 3b7eec2..0d18022 100644 > --- a/scripts/coccinelle/misc/bugon.cocci > +++ b/scripts/coccinelle/misc/bugon.cocci > @@ -57,6 +57,6 @@ coccilib.org.print_todo(p[0], "WARNING use BUG_ON") > p << r.p; > @@ > > -msg="WARNING: Use BUG_ON" > +msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease > make sure condition has no side effects (see conditional BUG_ON definition in > include/asm-generic/bug.h)" > coccilib.report.print_report(p[0], msg) "make sure condition" would be nicer as "make sure the condition". thanks, julia > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
