On 08/04/15 15:37, Irina Tirdea wrote: > When setting the activity period, the value introduced by > the user in sysfs is not checked for validity. > > Add a boundary check so that only allowed values are > reported as suuccesfully written to device. > > Signed-off-by: Irina Tirdea <[email protected]> > Suggested-by: Hartmut Knaack <[email protected]> Good point. This one counts as a fix so put it early in the reordered series. > --- > drivers/iio/accel/mma9553.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c > index 57868fb..96e4708 100644 > --- a/drivers/iio/accel/mma9553.c > +++ b/drivers/iio/accel/mma9553.c > @@ -839,6 +839,9 @@ static int mma9553_write_event_value(struct iio_dev > *indio_dev, > case IIO_EV_INFO_PERIOD: > switch (chan->type) { > case IIO_ACTIVITY: > + if (val < 0 || val > MMA9553_ACTIVITY_THD_TO_SEC( > + MMA9553_MAX_ACTTHD)) > + return -EINVAL; > mutex_lock(&data->mutex); > ret = mma9553_set_config(data, MMA9553_REG_CONF_ACTTHD, > &data->conf.actthd, >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
