Em Thu, May 07, 2015 at 10:05:28AM +0300, Adrian Hunter escreveu: > On 06/05/15 16:35, Arnaldo Carvalho de Melo wrote: > > Em Wed, May 06, 2015 at 10:14:36AM +0300, Adrian Hunter escreveu: > >> Perhaps we should disallow intel_bts and intel_pt PMU events > >> explicitly and put that change back to v4.1 stable at least? > >> > >> I tried adding: > >> > >> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > >> index 244c66f..5d3ab7c 100644 > >> --- a/tools/perf/util/pmu.c > >> +++ b/tools/perf/util/pmu.c > >> @@ -442,6 +442,10 @@ static struct perf_pmu *pmu_lookup(const char *name) > >> LIST_HEAD(aliases); > >> __u32 type; > >> > >> + /* No support for intel_bts or intel_pt so disallow them */ > >> + if (!strcmp(name, "intel_bts") || !strcmp(name, "intel_pt")) > >> + return NULL; > >> + > >> /* > >> * The pmu data we store & need consists of the pmu > >> * type value and format definitions. Load both right > >> > >> > >> And now I get: > >> > >> $ tools/perf/perf record -e intel_bts//u ls > >> invalid or unsupported event: 'intel_bts//u' > >> Run 'perf list' for a list of valid events > > > > Unsure, when did we start accepting intel_bts in event names? In this > > patchkit? > > Any old version of perf tools will accept PMU names as events. It validates > against /sys/bus/event_source/devices. > > So "intel_pt" and "intel_bts" will turn up in v4.1, so I was suggesting > disallowing them in perf tools for v4.1 since there is no tool support until > v4.2.
Well, please add that to some patchkit after I process the current set of patches, which I'll try to after pushing a batch that I have, to avoid spamming lkml too much each time :-) - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
