On Mon, May 11, 2015 at 05:21:06PM +0200, Niklas Cassel wrote: > Don't do clock-mode-select if clk == NULL, > since when building without CONFIG_HAVE_CLK, > clk_get returns NULL and clk_get_rate returns 0. > > Doing clock-mode-select in this cause causes kszphy_probe to > return -EINVAL and thus prevents the device from being probed. > > The original code (before regression) would return 0 > when building without CONFIG_HAVE_CLK. > > Cc: stable <[email protected]> # 3.18+ > 1fadee0c3645 ("net/phy: micrel: Add clock support for > KSZ8021/KSZ8031")
Looks like you forgot the "Fixes: " tag itself when updating. > Signed-off-by: Niklas Cassel <[email protected]> Look good otherwise, feel free to add my Reviewed-by: Johan Hovold <[email protected]> when resending (unless David wants to fix it up himself). Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
