* Rafael J. Wysocki <[email protected]> [150519 07:02]: > On Tuesday, May 19, 2015 04:04:43 PM Rafael J. Wysocki wrote: > > On Monday, May 18, 2015 04:44:01 PM Tony Lindgren wrote: > > > > > > For most drivers, we should be able to drop the following > > > boilerplate code from runtime_suspend and runtime_resume > > > functions: > > > > > > ... > > > device_init_wakeup(dev, true); > > > ... > > > if (device_may_wakeup(dev) > > > enable_irq_wake(irq); > > > ... > > > if (device_may_wakeup(dev) > > > enable_irq_wake(irq); > > > > Closing parens are missin in the above two if () statements. > > > > Also, should the second one be disable_irq_wake(irq)?
Thanks yeah it should disable_irq_wake :) Will fix. > > > ... > > > device_init_wakeup(dev, false); > > > ... > > > > > > We can replace it with just the following init and exit > > > time code: > > > > > > ... > > > device_init_wakeup(dev, true); > > > dev_pm_set_wake_irq(dev, irq); > > > ... > > > dev_pm_clear_wake_irq(dev); > > > device_init_wakeup(dev, false); > > > ... > > > > > > And for hardware with dedicated wake-up interrupts: > > > > > > ... > > > device_init_wakeup(dev, true); > > > dev_pm_set_dedicated_wake_irq(dev, irq); > > > ... > > > dev_pm_clear_wake_irq(dev); > > > device_init_wakeup(dev, false); > > > ... > > > > > > For now, let's only enable it for select PM_WAKEIRQ. > > > > Why? What would be wrong with doing that unconditionally? No reason to make it conditional any longer. it's there from the earlier version that only handled the dedicated wake IRQS. > I mean, what about making it depend on CONFIG_PM directly? OK let's do that. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
