On Wed, 20 May 2015, Oleg Nesterov wrote:
> On 05/19, Nicholas Mc Guire wrote: > > > > I assumed it would not matter but did not see a simple way of getting it > > type clean with unsigned either mainly due to the atomic_t being int and > > val in update_fast_ctr() being passed as -1. > > Perhaps clear_fast_ctr() should have a comment to explain why it returns > "int"... even if "unsigned" should work too. > > Please see https://lkml.org/lkml/2012/11/2/346 > thanks - makes it more clear to me where this came from - will give it another run and see how this could be resolved type clean. in any case I think that for such deliberate type missmatch it would be good to add an explicit cast so that it is clear that it was actually intended. thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
