On 06/01/2015 03:50 PM, Roger Pau Monné wrote: > El 26/05/15 a les 2.11, Bob Liu ha escrit: >> When migrate from !feature-persistent host to feature-persistent host, domU >> still think new host/backend don't support persistent. >> Dmesg like: >> backed has not unmapped grant: 839 >> backed has not unmapped grant: 773 >> backed has not unmapped grant: 773 >> backed has not unmapped grant: 773 >> backed has not unmapped grant: 839 >> >> We should recheck whether the new backend support feature-persistent during >> blkif_recover(). > > Right, we recheck for indirect-descriptors but not persistent grants. > > Do you think it makes sense to split the part of blkfront_connect that > checks for optional features, like persistent grants, indirect > descriptors and flush/barrier features to a separate function and call > it from both blkfront_connect and blkif_recover? >
Yep, that would be better. Thanks, -Bob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
