W dniu 02.06.2015 o 19:36, Laurentiu Palcu pisze: > Smatch static checker correctly detected an impossible condition because > chip_id was declared as u8, instead of int: > > drivers/power/bq25890_charger.c:843 bq25890_probe() > warn: impossible condition '(bq->chip_id < 0) => (0-255 < 0)' > > Also, while at it, fix the return value too.
I wondered whether this should be split into two commits... but actually returning uninitialized value is not possible now because of the cast, so: Reviewed-by: Krzysztof Kozlowski <[email protected]> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
