On Mon, Jun 8, 2015 at 12:04 PM, Andy Shevchenko <[email protected]> wrote: > On Mon, Jun 8, 2015 at 9:25 PM, Dan Williams <[email protected]> wrote: > >>>> + if (region_is_ram(offset, size) != 0) { >>>> + WARN_ONCE(1, "memremap attempted on ram %pa size: %zd\n", >>> >>> %zu >> >> Sure, thanks for taking a look Andy! > > One more thing, can we do > WARN_ONCE(region_is_ram(offset, size), …); ? >
We still want to return false in this case so it would become "if(WARN_ONCE(...)) return false;". Neil once made the argument to me that we should be able to compile all of the asserts out of the kernel, also "if (WARN_ONCE(...))" is a bit harder to read as you need to go check the macro to make sure it returns the right status, and more than once. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
