Hi Constantine,
On 06/24/2015 03:47 PM, Constantine Shulyupin wrote:
From: const <[email protected]>
Fixed registers are invisible only when registers' mode is 0
Signed-off-by: Constantine Shulyupin <[email protected]>
---
drivers/hwmon/nct7802.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
index ec56782..65e40c2 100644
--- a/drivers/hwmon/nct7802.c
+++ b/drivers/hwmon/nct7802.c
@@ -541,13 +541,11 @@ static umode_t nct7802_temp_is_visible(struct kobject
*kobj,
if (err < 0)
return 0;
- if (index < 9 &&
- (reg & 03) != 0x01 && (reg & 0x03) != 0x02) /* RD1 */
+ if (index < 9 && !(reg & 0x03)) /* RD1 */
return 0;
- if (index >= 9 && index < 18 &&
- (reg & 0x0c) != 0x04 && (reg & 0x0c) != 0x08) /* RD2 */
+ if (index >= 9 && index < 18 && !(reg & 0x0c)) /* RD2 */
return 0;
- if (index >= 18 && index < 27 && (reg & 0x30) != 0x10) /* RD3 */
+ if (index >= 18 && index < 27 && !(reg & 0x30)) /* RD3 */
11b sets a sensor to voltage sense mode, not temperature mode.
This is what the inX attributes are for. We can not just display a
random temperature value if a sensor is configured to measure a voltage.
According to my datasheet, 01b (0x10 shifted) is reserved for RD3.
So there is a bug, but it is
if (index >= 18 && index < 27 && (reg & 0x30) != 0x10) /* RD3 */
which should be
if (index >= 18 && index < 27 && (reg & 0x30) != 0x20) /* RD3 */
Can you send an updated patch ?
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
