On Fri 22-05-15 17:13:56, Tejun Heo wrote: > wakeup_dirtytime_writeback() currently only starts writeback on the > root wb (bdi_writeback). For cgroup writeback support, update the > function to check all wbs. > > Signed-off-by: Tejun Heo <[email protected]> > Cc: Jens Axboe <[email protected]> > Cc: Jan Kara <[email protected]> > Cc: Theodore Ts'o <[email protected]>
Looks good. You can add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/fs-writeback.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 508e10c..8ae212e 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -1260,9 +1260,12 @@ static void wakeup_dirtytime_writeback(struct > work_struct *w) > > rcu_read_lock(); > list_for_each_entry_rcu(bdi, &bdi_list, bdi_list) { > - if (list_empty(&bdi->wb.b_dirty_time)) > - continue; > - wb_wakeup(&bdi->wb); > + struct bdi_writeback *wb; > + struct wb_iter iter; > + > + bdi_for_each_wb(wb, bdi, &iter, 0) > + if (!list_empty(&bdi->wb.b_dirty_time)) > + wb_wakeup(&bdi->wb); > } > rcu_read_unlock(); > schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ); > -- > 2.4.0 > -- Jan Kara <[email protected]> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
