On Thu, Jul 02, 2015 at 11:02:54AM +0000, Maninder Singh wrote: > Hello charles, > >> pdata is used before NULL check, so it looks misleading. > >> If pdata validation is required then we have to > >> first check for pdata validation, then calculate id, > >> and then second check for pdata->dcdc[id]. > >> > >> and it is better to use !pointer than (pointer == NULL) > >> > >> Signed-off-by: Maninder Singh <[email protected]> > >> --- > > >The patch basically looks fine, but it feels a bit like needless > >churn. The current code is perfectly correct and feels clear > >enough to me. > > Reason for patch is we are checking a pointer which is already dereferenced > before NULL check, which looks misleading. > If we know code is working correctly, Then we may simply drop NULL check, > rather than these changes.
You can't drop the NULL check because then we might dereference a NULL pointer. ARRAY_SIZE(pdata->dcdc) is perfectly save because sizeof only works on types so no actual dereference takes place. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
