On Thu, Jul 02, 2015 at 12:14:56PM +0100, Mark Brown wrote: > On Thu, Jul 02, 2015 at 11:18:49AM +0100, Charles Keepax wrote: > > On Thu, Jul 02, 2015 at 01:27:09PM +0530, Maninder Singh wrote: > > > pdata is used before NULL check, so it looks misleading. > > > The patch basically looks fine, but it feels a bit like needless > > churn. The current code is perfectly correct and feels clear > > enough to me. > > It's a bug - either the validation shouldn't be there or it needs to be > before the use otherwise it does nothing.
ARRAY_SIZE being implemented with sizeof's means that no actual dereference takes place. But if we have multiple people thinking this looks buggy then I guess the code probably isn't clear enough at the moment. Acked-by: Charles Keepax <[email protected]> Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
