On 6 July 2015 at 23:26, Vaishali Thakkar <[email protected]> wrote: > Use module_platform_driver for drivers whose init and exit functions > only register and unregister, respectively. > > A simplified version of the Coccinelle semantic patch that performs > this transformation is as follows: > > @a@ > identifier f, x; > @@ > -static f(...) { return platform_driver_register(&x); } > > @b depends on a@ > identifier e, a.x; > @@ > -static e(...) { platform_driver_unregister(&x); } > > @c depends on a && b@ > identifier a.f; > declarer name module_init; > @@ > -module_init(f); > > @d depends on a && b && c@ > identifier b.e, a.x; > declarer name module_exit; > declarer name module_platform_driver; > @@ > -module_exit(e); > +module_platform_driver(x); > > Signed-off-by: Vaishali Thakkar <[email protected]> > --- > drivers/hwtracing/coresight/coresight-replicator.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c > b/drivers/hwtracing/coresight/coresight-replicator.c > index 7974b7c..df45932 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -183,18 +183,7 @@ static struct platform_driver replicator_driver = { > .pm = &replicator_dev_pm_ops, > }, > }; > - > -static int __init replicator_init(void) > -{ > - return platform_driver_register(&replicator_driver); > -} > -module_init(replicator_init); > - > -static void __exit replicator_exit(void) > -{ > - platform_driver_unregister(&replicator_driver); > -} > -module_exit(replicator_exit); > +module_platform_driver(replicator_driver); > > MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("CoreSight Replicator driver"); > -- > 1.9.1 >
I agree with this patch but please remove the comment about Coccinelle in the commit log (along with the code) and add a newline before module_platform_driver(). Thanks, Mathieu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
