On 15/07/12, Mustapha Abiola wrote: > >From 55fae099d46749b73895934aab8c2823c5a23abe Mon Sep 17 00:00:00 2001 > From: Mustapha Abiola <[email protected]> > Date: Sat, 11 Jul 2015 17:01:04 +0000 > Subject: [PATCH 1/1] Fix redundant check against unsigned int in broken audit > test fix for exec arg len > > Quick patch to fix the needless check of `len` being < 0 as its an unsigned > int.
If you are able, it is much easier to use "git format-patch ..." and "git send-email ...". Something in your workflow is double-spacing your message... I echo Paul's recommendation... > Signed-off-by: Mustapha Abiola <[email protected]> > > --- > > kernel/auditsc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > > index e85bdfd..0012476 100644 > > --- a/kernel/auditsc.c > > +++ b/kernel/auditsc.c > > @@ -1021,7 +1021,7 @@ static int audit_log_single_execve_arg(struct > audit_context *context, > > * for strings that are too long, we should not have created > > * any. > > */ > > - if (WARN_ON_ONCE(len < 0 || len > MAX_ARG_STRLEN - 1)) { > > + if (WARN_ON_ONCE(len > MAX_ARG_STRLEN - 1)) { > > send_sig(SIGKILL, current, 0); > > return -1; > > } > > -- > > 1.9.1 > -- > Linux-audit mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/linux-audit - RGB -- Richard Guy Briggs <[email protected]> Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
