On Thu, Jul 16, 2015 at 4:46 AM, Brian Gerst <[email protected]> wrote:
> Move the userspace accesses down into the common function in
> preparation for the next set of patches.
Nice!
Could you improve the changelog a bit? You're really changing the way
it works (in a good way).
> - set_flags(regs->pt.flags, VEFLAGS, X86_EFLAGS_VIF |
> current->thread.v86mask);
> - tmp = copy_vm86_regs_to_user(¤t->thread.vm86_info->regs, regs);
> - tmp += put_user(current->thread.screen_bitmap,
> ¤t->thread.vm86_info->screen_bitmap);
> - if (tmp) {
> + set_flags(regs->pt.flags, VEFLAGS, X86_EFLAGS_VIF |
> tsk->thread.v86mask);
> + user = tsk->thread.vm86_info;
> + put_user_try {
I think that put_user_try/put_user_ex requires access_ok.
> + get_user_try {
> + unsigned short seg;
This also needs access_ok, I think.
--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
