On 23-07-15, 00:27, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[email protected]> > > After commit 9b07109f06a1 (cpufreq: Fix double addition of sysfs > links) the second sif argument of __cpufreq_remove_dev_prepare() > and __cpufreq_remove_dev_finish() is not used by them any more. > > However, there also is a problem in cpufreq_remove_dev() that > if any of the above functions returns an error, we'll fail to > clean up after a CPU that is going away (and it is going away > no matter what). Moreover, error codes returned by them are > ignored by cpufreq_cpu_callback(), so even if any of them is > aborted and returns an error code, the caller of the notifier > callback will not know about that. > > For this reason, make __cpufreq_remove_dev_prepare() and > __cpufreq_remove_dev_finish() never fail, change them to void > functions and drop the sif argument from them. > > Signed-off-by: Rafael J. Wysocki <[email protected]> > --- > > On top of: > http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=9b07109f06a1edd6e636b1e7397157eae0e6baa4 > > Note: The commit mentioned above is on a testing branch only > at the moment. > > Well, I seem to be blind.
Acked-by: Viresh Kumar <[email protected]> -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
