Hi, On 30/07/2015 at 15:59:57 -0700, Greg Kroah-Hartman wrote : > From: Greg Kroah-Hartman <[email protected]> > > With well over 200+ users of this api, there are a mere 12 users that > actually cheked the return value of this function. And all of them ^ small typo here
> really didn't do anything with that information as the system or module > was shutting down no matter what. > > So stop pretending like it matters, and just return void from > misc_deregister(). If something goes wrong in the call, you will get a > WARNING splat in the syslog so you know how to fix up your driver. > Other than that, there's nothing that can go wrong. > > Cc: Alasdair Kergon <[email protected]> > Cc: Mike Snitzer <[email protected]> > Cc: Neil Brown <[email protected]> > Cc: Alessandro Zummo <[email protected]> > Cc: Alexandre Belloni <[email protected]> > Cc: Oleg Drokin <[email protected]> > Cc: Andreas Dilger <[email protected]> > Cc: "Michael S. Tsirkin" <[email protected]> > Cc: Wim Van Sebroeck <[email protected]> > Cc: Christine Caulfield <[email protected]> > Cc: David Teigland <[email protected]> > Cc: Mark Fasheh <[email protected]> > Cc: Joel Becker <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> For rtc and at91rm9200_wdt.c: Acked-by: Alexandre Belloni <[email protected]> [...] > --- a/drivers/watchdog/at91rm9200_wdt.c > +++ b/drivers/watchdog/at91rm9200_wdt.c > @@ -269,9 +269,8 @@ static int at91wdt_remove(struct platfor > if (res) > dev_warn(dev, "failed to unregister restart handler\n"); > > - res = misc_deregister(&at91wdt_miscdev); > - if (!res) > - at91wdt_miscdev.parent = NULL; > + misc_deregister(&at91wdt_miscdev); > + at91wdt_miscdev.parent = NULL; > > return res; That one was actually doing something with the return value ;) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
