From: Dan Carpenter <[email protected]>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

commit 4a102b4d144f0422eb8b0a59c7cb194bf12163a9 upstream.

There is a bug in omap2_mbox_probe() where we try do:

                mbox->irq = platform_get_irq(pdev, info->irq_id);
                if (mbox->irq < 0) {

The problem is that mbox->irq is unsigned so the error handling doesn't
work.  I've changed it to a signed integer.

Signed-off-by: Dan Carpenter <[email protected]>
Cc: Suman Anna <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Omar Ramirez Luna <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Cc: Oliver Neukum <[email protected]>
Signed-off-by: Jiri Slaby <[email protected]>
---
 drivers/mailbox/omap-mbox.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mailbox/omap-mbox.h b/drivers/mailbox/omap-mbox.h
index 6cd38fc68599..86d7518cd13b 100644
--- a/drivers/mailbox/omap-mbox.h
+++ b/drivers/mailbox/omap-mbox.h
@@ -52,7 +52,7 @@ struct omap_mbox_queue {
 
 struct omap_mbox {
        const char              *name;
-       unsigned int            irq;
+       int                     irq;
        struct omap_mbox_queue  *txq, *rxq;
        struct omap_mbox_ops    *ops;
        struct device           *dev;
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to