On Wed, Aug 05, 2015 at 09:29:11AM +0100, Javi Merino wrote: > On Tue, Aug 04, 2015 at 05:33:40PM +0100, Dmitry Torokhov wrote: > > The code in question is called outside of standard driver > > probe()/remove() callbacks and thus will not benefit from use of devm* > > infrastructure. > > > > Signed-off-by: Dmitry Torokhov <[email protected]> > > We added the devm* calls because Eduardo asked for them in the review. > I don't have a strong opinion regarding this, I'll leave the decision > to Eduardo.
I tried to look for his reasons, if any, but even in earliest posted versions use devm* for allocating memory I guess this is one of examples of devm* usage in wrong context. Given that you, as you have to, because this is not a device driver, manually freeing that memory with devm_kfree(), the only thing that devm_kzalloc and friends buy you here is extra memory allocations for devres structures and few extra cycles for maintaining them. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
