On Wed, Aug 12, 2015 at 12:12:37PM +0200, Markus Pargmann wrote:

> +     /* if set, raw reads/writes are limited to this size */
> +     size_t max_raw_io;
> +

Do this separately for read and write, there's doubtless going to be
something that has asymmetry.

> +             if (!map->use_single_rw) {
> +                     write_count = total_bytes / map->max_raw_io;
> +                     write_bytes = map->max_raw_io;

We may not be able to fit a whole number of values into whatever the
constraint that the bus has is and partial values don't seem like a good
idea.

> +                     reg_stride *= write_bytes / val_bytes;
> +             }

This is very confusing, regmap already has a concept of stride and this
isn't the same thing.

Attachment: signature.asc
Description: Digital signature

Reply via email to