The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config symbol because the driver uses some communication helper functions in drivers/platform/chrome/cros_ec_proto.c but other drivers depends on CROS_EC_PROTO instead. Mixing select and depends can lead to circular Kconfig dependencies so the MFD_CROS_EC select should be changed to a depends on CROS_EC_PROTO instead.
But doing so will break git bisect-ability since MFD_CROS_EC will not be enabled anymore unless the default configs first explicitly enable the CROS_EC_PROTO dependency. Signed-off-by: Javier Martinez Canillas <[email protected]> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index b2facab87399..bd406f660ffe 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -619,6 +619,7 @@ CONFIG_QCOM_PM=y CONFIG_COMMON_CLK_QCOM=y CONFIG_CHROME_PLATFORMS=y CONFIG_CROS_EC_CHARDEV=m +CONFIG_CROS_EC_PROTO=y CONFIG_COMMON_CLK_MAX77686=y CONFIG_COMMON_CLK_MAX77802=m CONFIG_COMMON_CLK_S2MPS11=m -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
