On Wed, Aug 19, 2015 at 12:28:37AM +0200, Javier Martinez Canillas wrote: > Hello Olof, > > On 08/18/2015 11:46 PM, Olof Johansson wrote: > > On Tue, Aug 18, 2015 at 09:10:27AM +0200, Javier Martinez Canillas wrote: > >> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config > >> symbol because the driver uses some communication helper functions in > >> drivers/platform/chrome/cros_ec_proto.c but other drivers depends on > >> CROS_EC_PROTO instead. Mixing select and depends can lead to circular > >> Kconfig dependencies so the MFD_CROS_EC select should be changed to a > >> depends on CROS_EC_PROTO instead. > >> > >> But doing so will break git bisect-ability since MFD_CROS_EC will not > >> be enabled anymore unless the default configs first explicitly enable > >> the CROS_EC_PROTO dependency. > >> > >> Signed-off-by: Javier Martinez Canillas <[email protected]> > > > > Applied to cros/ec-config in arm-soc, which will stay stable in case others > > need to bring in as a prereq. > > > > Thanks but Bartolomiej's feedback [0] on my patch that made CROS_EC_PROTO > a user selectable option was to leave it as a non-visible option and instead > change the other Kconfig symbols to select CROS_EC_PROTO consistently. > > So tomorrow I'll post a new patch series along those lines that will make > this patch obsolete since no defconfig changes will be needed. > > IOW, please drop this patch and sorry for the inconvenience.
Done. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
