On Tue, Aug 18, 2015 at 05:25:38AM -0400, [email protected] wrote:
> From: Kan Liang <[email protected]>
>
> This patch enable perf report to sort by socket
>
SNIP
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 7e38716..245e254 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -421,6 +421,33 @@ struct sort_entry sort_cpu = {
> .se_width_idx = HISTC_CPU,
> };
>
> +/* --sort socket */
> +
> +static int64_t
> +sort__socket_cmp(struct hist_entry *left, struct hist_entry *right)
> +{
> + int r_socket, l_socket;
> +
> + r_socket = cpu__get_socket(right->cpu);
> + l_socket = cpu__get_socket(left->cpu);
> + return r_socket - l_socket;
we need global topology information in perf.data and use
the mapping from there, we can't use current server info
we currently store core_siblings_list and thread_siblings_list,
in topology FEATURE, which is probably not enough
I think we need new feature that stores topology info and
new interface that will provide all useful mappings:
idx -> cpu
cpu -> core
cpu -> socket
cpu -> node
in another patchset I used new CPUMAP event:
https://git.kernel.org/cgit/linux/kernel/git/jolsa/perf.git/commit/?h=perf/stat_script_3&id=37b7b8449aa23acdfe9dec5a7a371e91c5323da5
we might need both ways (new FEATURE and event) to support pipe reports
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
