On 2015-08-26 05:47, Linus Walleij wrote: > On Sat, Aug 22, 2015 at 12:56 AM, Stefan Agner <[email protected]> wrote: > >> The GPIO IRQ controller is able to generate level triggered >> interrupts, however, these were handled by handle_simple_irq so far >> which did not take care of IRQ masking. This lead to "nobody cared >> (try booting with the "irqpoll" option)" stack traces. >> >> Use the generic interrupt handlers depending on the IRQ type. >> >> Signed-off-by: Stefan Agner <[email protected]> > > Patch applied.
Thx > Hm, this looks like a problem that could exist in a few more > GPIO drivers. Can you look around and see if there is something > immediately suspicious in drivers/gpio? Just looked a bit around. There are some which use handle_simple_irq but also run their handler in threaded/one-shot handler. I guess in that case it is fine to use the simple_irq handler. However, those GPIO drivers look suspicious: gpio-altera.c: Uses handle_simple_irq, supports edge and level gpio-bcm-kona.c: Uses handle_simple_irq, supports only edge gpio-grgpio.c: Uses handle_simple_irq, supports edge and level gpio-intel-mid.c: Uses handle_simple_irq, supports only edge gpio-lynxpoint.c: Uses handle_simple_irq, supports edge and level gpio-ml-ioh.c: Uses handle_simple_irq, supports edge and level gpio-pl061.c: Uses handle_simple_irq, supports edge and level gpio-rcar.c: Uses handle_level_irq, supports edge and level gpio-timberdale.c: Uses handle_simple_irq, supports edge and level -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
