* Dave Hansen <[email protected]> wrote:
>
> From: Dave Hansen <[email protected]>
>
> LightWeight Profiling was evidently an AMD profiling feature that
> we never got around to implementing. Remove the references to it.
>
> This patch is a *bit* worrisome becuase it will implicitly cause
> 'struct xregs_state' to shrink. This effectively removes some
> unused padding that we had in there. It might expose other bugs.
>
> Signed-off-by: Dave Hansen <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: [email protected]
> Cc: Borislav Petkov <[email protected]>
> Cc: Fenghua Yu <[email protected]>
> Cc: Tim Chen <[email protected]>
> Cc: [email protected]
> ---
>
> b/arch/x86/include/asm/fpu/types.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff -puN arch/x86/include/asm/fpu/types.h~axe-lwp
> arch/x86/include/asm/fpu/types.h
> --- a/arch/x86/include/asm/fpu/types.h~axe-lwp 2015-08-27
> 10:08:01.195617135 -0700
> +++ b/arch/x86/include/asm/fpu/types.h 2015-08-27 10:08:01.198617272
> -0700
> @@ -132,11 +132,6 @@ struct ymmh_struct {
> u8 ymmh_space[256];
> };
>
> -/* We don't support LWP yet: */
> -struct lwp_struct {
> - u8 reserved[128];
> -};
> -
> /* Intel MPX support: */
> struct bndreg {
> u64 lower_bound;
> @@ -161,7 +156,6 @@ struct xstate_header {
>
> /* New processor state extensions should be added here: */
> #define XSTATE_RESERVE (sizeof(struct ymmh_struct) + \
> - sizeof(struct lwp_struct) + \
> sizeof(struct mpx_struct) )
Btw., now that we allocate all this dynamically and sanity-check that the CPU
gives us, I'd suggest we remove the XSTATE_RESERVE define altogether, and any
excess __reserved[] bytes from the xstate header:
struct xregs_state {
struct fxregs_state i387;
struct xstate_header header;
u8 __reserved[XSTATE_RESERVE];
} __attribute__ ((packed, aligned (64)));
any latent bug this might trigger we want to fix.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
