On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote:
> The command of install could not handle the special files in exec
> testcases, change the default rule to rsync to fix this.
> The result of installation is unchanged after this commit.
>
> Suggested-by: Michael Ellerman <m...@ellerman.id.au>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangj...@linaro.org>
Ah OK, I did suggest it. You never replied to my mail suggesting it though.
I assume you tested it and it worked for all cases?
> diff --git a/tools/testing/selftests/ftrace/Makefile
> b/tools/testing/selftests/ftrace/Makefile
> index 0acbeca..4e6ed13 100644
> --- a/tools/testing/selftests/ftrace/Makefile
> +++ b/tools/testing/selftests/ftrace/Makefile
> @@ -1,7 +1,7 @@
> all:
>
> TEST_PROGS := ftracetest
> -TEST_DIRS := test.d/
> +TEST_DIRS := test.d
>
> include ../lib.mk
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 97f1c67..50a93f5 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -12,13 +12,10 @@ run_tests: all
> $(RUN_TESTS)
>
> define INSTALL_RULE
> - @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ];
> then \
> - mkdir -p $(INSTALL_PATH);
> \
> - for TEST_DIR in $(TEST_DIRS); do
> \
> - cp -r $$TEST_DIR $(INSTALL_PATH);
> \
> - done;
> \
> - echo "install -t $(INSTALL_PATH) $(TEST_PROGS)
> $(TEST_PROGS_EXTENDED) $(TEST_FILES)"; \
> - install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED)
> $(TEST_FILES); \
> + @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ];
> then \
> + mkdir -p ${INSTALL_PATH};
> \
> + echo "rsync -a $(TEST_DIRS) $(TEST_PROGS)
> $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(INSTALL_PATH)/"; \
What is the echo for?
> + rsync -a $(TEST_DIRS) $(TEST_PROGS) $(TEST_PROGS_EXTENDED)
> $(TEST_FILES) $(INSTALL_PATH)/; \
> fi
> endef
>
cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
