On (09/18/15 14:19), Joonsoo Kim wrote:
[..]
> +     /*
> +      * Prepare to use crypto decompress_noctx API. One tfm is required
> +      * to initialize crypto algorithm properly and fetch corresponding
> +      * function pointer. But, it is sharable for multiple concurrent
> +      * decompress users.
> +      */

if comp algorithm require zstrm for both compression and decompression,
then there seems to be no need in allocating sharable ->tfm_noctx, we
will never use it.

        -ss

> +     tfm = crypto_alloc_comp_noctx(compress, 0, 0);
> +     if (!IS_ERR(tfm))
> +             comp->tfm_noctx = tfm;
> +
>       return comp;
>  }
> diff --git a/drivers/block/zram/zcomp.h b/drivers/block/zram/zcomp.h
> index 4f9df8e..c76d8e4 100644
> --- a/drivers/block/zram/zcomp.h
> +++ b/drivers/block/zram/zcomp.h
> @@ -26,6 +26,7 @@ struct zcomp_strm {
>  /* dynamic per-device compression frontend */
>  struct zcomp {
>       void *stream;
> +     struct crypto_comp *tfm_noctx;
>       const char *backend;
>  
>       struct zcomp_strm *(*strm_find)(struct zcomp *comp);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to