On 09/10/2015 15:24, Daniel Lezcano wrote: > On 10/09/2015 02:13 PM, Marc Gonzalez wrote: >> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator. >> Use it for clocksource, sched_clock, and delay_timer. >> >> Signed-off-by: Marc Gonzalez <[email protected]> >> --- >> I have a nagging feeling that the QUIT_IF macro will get this patch NAKed ;-) >> My rationale: error-handling tends to take the focus away from the normal >> path, and put it on the error path. Hiding the details away in a macro >> helps to keep the error-handling noise to a minimum. > > It is a right feeling :) > > The Linux kernel code follows the same path all across the different > sub-systems. So it is not a problem to write: if (err) ..., people is > used to read such code and by introducing this macro, that makes the > code less readable for them. > > Moreover, the way you wrote the macro is strongly discouraged in the > CodingStyle document because there is a 'return' inside.
New patch coming right up. On a tangential subject, it would seem that platforms with verbose logs at init might benefit from marking as __initconst strings used in __init functions. I discussed this some time ago: https://lkml.org/lkml/2015/3/25/688 which pointed to an earlier discussion: https://lkml.org/lkml/2014/8/21/255 https://lkml.org/lkml/2014/6/22/149 Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
