2015-10-12 14:09+0200, Paolo Bonzini: > The next patch will make x86_set_memory_region fill the > userspace_addr. Since the struct is not used untouched > anymore, it makes sense to build it in x86_set_memory_region > directly; it also simplifies the callers. > > Reported-by: Alexandre DERUMIER <[email protected]> > Cc: [email protected] > Fixes: 9da0e4d5ac969909f6b435ce28ea28135a9cbd69 > Signed-off-by: Paolo Bonzini <[email protected]> > --- > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > @@ -1199,9 +1199,7 @@ void kvm_complete_insn_gp(struct kvm_vcpu *vcpu, int > err); > -int __x86_set_memory_region(struct kvm *kvm, > - const struct kvm_userspace_memory_region *mem); > -int x86_set_memory_region(struct kvm *kvm, > - const struct kvm_userspace_memory_region *mem); > +int __x86_set_memory_region(struct kvm *kvm, int id, gpa_t gpa, u32 size); > +int x86_set_memory_region(struct kvm *kvm, int id, gpa_t gpa, u32 size);
kvm_userspace_memory_region has u64 size, but we only use this for few pages anyway and will hopefully get a warning from GCC if that changes. Patch makes the code much better, Reviewed-by: Radim Krčmář <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
