Re: [PATCH v23 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc

[Jakub Kicinski]

On Sun, 13 Jul 2025 12:52:29 +0200 chia-yu.ch...@nokia-bell-labs.com
wrote:
> +     err = nla_parse_nested(tb, TCA_DUALPI2_MAX, opt, dualpi2_policy,
> +                            extack);
> +     if (err < 0)
> +             return err;

We should probably have:

+       if (tb[TCA_DUALPI2_STEP_THRESH_PKTS] && tb[TCA_DUALPI2_STEP_THRESH_US]) 
{
+               NL_SET_ERR_MSG_MOD(extack, "multiple step thresh attributes");
+               return -EINVAL;
+       }

here?