> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Thursday, July 17, 2025 1:48 AM
> To: Chia-Yu Chang (Nokia) <chia-yu.ch...@nokia-bell-labs.com>
> Cc: alok.a.tiw...@oracle.com; pctamm...@mojatatu.com; ho...@kernel.org;
> donald.hun...@gmail.com; xandf...@gmail.com; net...@vger.kernel.org;
> dave.t...@gmail.com; pab...@redhat.com; j...@mojatatu.com;
> step...@networkplumber.org; xiyou.wangc...@gmail.com; j...@resnulli.us;
> da...@davemloft.net; eduma...@google.com; andrew+net...@lunn.ch;
> a...@fiberby.net; liuhang...@gmail.com; sh...@kernel.org;
> linux-kselftest@vger.kernel.org; i...@kernel.org; ncardw...@google.com; Koen
> De Schepper (Nokia) <koen.de_schep...@nokia-bell-labs.com>;
> g.wh...@cablelabs.com; ingemar.s.johans...@ericsson.com;
> mirja.kuehlew...@ericsson.com; chesh...@apple.com; rs.i...@gmx.at;
> jason_living...@comcast.com; vidhi_g...@apple.com
> Subject: Re: [PATCH v23 net-next 1/6] sched: Struct definition and parsing of
> dualpi2 qdisc
>
>
> CAUTION: This is an external email. Please be very careful when clicking
> links or opening attachments. See the URL nok.it/ext for additional
> information.
>
>
>
> On Sun, 13 Jul 2025 12:52:29 +0200 chia-yu.ch...@nokia-bell-labs.com
> wrote:
> > + err = nla_parse_nested(tb, TCA_DUALPI2_MAX, opt, dualpi2_policy,
> > + extack);
> > + if (err < 0)
> > + return err;
>
> We should probably have:
>
> + if (tb[TCA_DUALPI2_STEP_THRESH_PKTS] &&
> tb[TCA_DUALPI2_STEP_THRESH_US]) {
> + NL_SET_ERR_MSG_MOD(extack, "multiple step thresh attributes");
> + return -EINVAL;
> + }
>
> here?
Yes, you are right. I will add that in the next version.
