On Wed, Dec 3, 2014 at 3:28 PM, Fabio Estevam <[email protected]> wrote: > On Wed, Dec 3, 2014 at 9:17 PM, Grant Likely <[email protected]> wrote: >> On Wed, Dec 3, 2014 at 5:57 PM, Fabio Estevam <[email protected]> wrote: >>> From: Fabio Estevam <[email protected]> >>> >>> Since commit a43f2cbbb009f96 ("leds: leds-gpio: Make use of device property >>> API") it is no longer possible to register multiple gpio leds without >>> passing >>> the 'label' property. >>> >>> According to Documentation/devicetree/bindings/leds/common.txt: >>> >>> "Optional properties for child nodes: >>> - label : The label for this LED. If omitted, the label is >>> taken from the node name (excluding the unit address)." >>> >>> So retrieve the node name when the 'label' property is absent to keep the >>> old >>> behaviour and fix this regression. >>> >>> Reported-by: Jean-Michel Hautbois <[email protected]> >>> Signed-off-by: Fabio Estevam <[email protected]> >> >> Acked-by: Grant Likely <[email protected]> >> >> (Assuming that creating a fwnode_get_name() function turns out to be a >> non-starter.) > > Thanks, Grant. > > Maybe we should go with this v2 patch initially to fix the regression > and then we could consider introducing fwnode_get_name() in a future > patch.
I think V1 just touches leds-gpio.c and might be easier to merge as a good fix. And then you can provide a patch to introduce fwnode_get_name(). Or you update your V2 patch to use fwnode_get_name() and try to merge it as a fix. -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
