On Fri, 11 Feb 2005, Finn Thain wrote:
On Thu, 10 Feb 2005, Brad Boyer wrote:
On Fri, Feb 11, 2005 at 02:05:14AM +1100, Finn Thain wrote:
Well, it fixed the build failure, but when I tested the kernel I get a new error at bootup,
scsi HBA driver Macintosh NCR5380 SCSI didn't set a release method.
Having finally looked at the definition of the __devexit_p macro, it seems to me that the release method is supposed to be a null pointer. So Noah's patch is not the problem at all, but it is not the entire solution either. This patch is needed as well.
Signed-off-by: Finn Thain <[EMAIL PROTECTED]>
--- a/drivers/scsi/scsi_module.c 2005-02-13 14:42:43.265174749 +1100
+++ b/drivers/scsi/scsi_module.c 2005-02-13 14:59:08.188565188 +1100
@@ -21,7 +21,7 @@
struct list_head *l;
int error;- if (!sht->release) {
+ if (!sht->release && __devexit_p((void *)1)) {
printk(KERN_ERR
"scsi HBA driver %s didn't set a release method.\n",
sht->name);
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
