On Sun, Feb 13, 2005 at 05:01:43PM +1100, Finn Thain wrote: > On Sat, 12 Feb 2005, Noah Misch wrote: > >On Sat, Feb 12, 2005 at 09:49:57PM +1100, Finn Thain wrote: > >>+#if defined(MODULE) || defined(CONFIG_HOTPLUG) > > > >An __exit function calls sht->release, so #ifdef MODULE is sufficient. > > I don't agree. MODULE is insufficient because when CONFIG_HOTPLUG is > undefined and this driver is built into the kernel, it will not load. This > is because the release method will be NULL, because your patch assigns > .release = __devexit_p(macscsi_release).
Neither way will the check run for !MODULE,!HOTPLUG. By checking HOTPLUG besides, you additionally permit the check for !MODULE, HOTPLUG. In that configuration, it is legitimate for sht->release to be NULL because exit_this_scsi_driver, its eventual caller, will be discarded. Of course, I could be missing something. - To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
